Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation tracking to show invalid without spamming with input errors #699

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

garrettmflynn
Copy link
Member

This PR ensures that the form status (e.g. colored accents) are rendered appropriately without spamming the UI with input errors.

This is an improvement on Ben's suggestion to block validation until user interaction, which originally was not properly indicating when forms were invalid (at a high level) before interaction. This was missed because we only used this feature on pop-up forms that were not showing this.

While this was discovered and tested on the Path Expansion page, it's actually more appropriate for that page to have suggested requirements than interaction-based validation. So this was also updated in this PR.

@garrettmflynn garrettmflynn self-assigned this Mar 25, 2024
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge March 25, 2024 18:17
@CodyCBakerPhD CodyCBakerPhD merged commit de93c84 into main Mar 25, 2024
15 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the track-validation-without-display branch March 25, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants